I wouldn’t call it an “orienting phase” but rather a fixed hardcoded flight path which is always flown no matter if it makes sense or not. The missile launches vertically and gets horizontal into the direction where the target was at the moment of launch (not the calculated interception point). After that it changes to a dynamic flight path. It doesn’t make any sense to ever have that coded to begin with. I don’t know why they thought it was ever needed…
1 Like
Its literally called “orientationAutopilot” in the code, so calling it the “orienting phase” is correct.
Sidenote, the bracket syntax used in the code bugs me more and more every time I dig through this code…
1 Like
Seriously? So just remove that “autopilot” block to have it work correctly?
That’s a JSON format if I’m seeing it right and effectively a standard for network communication. It can also be and is also used as a configuration format like YAML, TOML, etc.
If you have an IDE with hightlighting it’s quite comfortable to read ^^
Example:
object {
data,
of,
object,
'list': [
list,
of,
values,
for,
datapoint,
'list',
]
}
Maybe? Not sure how the missile behaves without it, but seeing as gaijin made it, its likely they had a reason to do so. My guess is either the loft code doesnt work properly in vertical launches, or the missile is missing shots it shouldnt at close range (and the current iteration we have in-game already underperforms stated irl figures for the SLM in that regard iirc). Idk of anyone really messing around with missile code lately though tbh, so idk if anyone will ever play around with that for testing…
Not the overall format itself that bugs me, its just that back when I learned coding, teachers were really strict on readability of code, so one of the really nice and easy way to format brackets specifically we were taught was aligning opening and closing brackets, so they were intuitively paired at a glance. Brackets aren’t lined up in this code (or your example). I just hate having to count brackets lol.
Example
2 Likes
I’m afraid it wouldn’t be this simple, maybe the game relies on this block of code for a reason, removing it could result in something entirely different or the game just crashing upon firing a missile. If it’s there, it is for a reason, lofting is something Gaijin has always struggled with.
i want to strangle the person who wrote the array like that
4 Likes
Yeah that’s C/C++ Style bracketing. JSON comes from the JavaScript corner so the style is different. Personally for programming I like the C/C++ tyle more too, but for JSON I prefer the “same line bracket start”.
It’s not an array but a list and absolutely alright in my eyes (as it adheres to the JSON specification) :P
an array is a list of values
Array is a linear data structure where all elements are arranged sequentially.
1 Like
For me an array was always a structure where you have to set the index manually for every value you add and you have a static size which is set on initialization. Not so with a list.
We probs shouldnt keep discussing coding formats and terms in the IRIS-T SLM thread lol
1 Like
and they still store values in sequence both of them
how you add the values simply dosent matter, especially since they are hardcoded in the case of WT
Well, all the SLM problems are coding problems, so why not? xD
1 Like
yeah lets move it to the PUMA thread probably the vehicle plauged most by gaijins code
4 Likes
It’s not the worst I’ve seen, it’s perfectly readable syntax but I’m not that familiar with JSON.
Discussing the SLM code is a little different than discussing coding in general lol
1 Like
Yeah that’s true and the reason why I should have put a \s at the end of my post ^^
putting each value in an extra line just makes the code unecesarily long and harder to read, especially since each of those values are magic numbers anyways
1 Like
I spent some time looking at it, it’s just the object responsible for the double loft. When you launch the missile it first goes vertical until a certain altitude above the ground, then this block of variables will take over the guidance to “orient” the missile in the right direction, and tells it to head over the target in the weird shallow angles we have in the game. Hence, the weird “double loft”.
But I dunno man, it’s been ages since I looked at coding.
1 Like
the fact that you had to look at it and think about it for around 15 minutes just shows that it is badly readable code
big point of that are the magic numbers you tried to figure out here
I mean, it’s pretty self explanatory what’s going on in that block of variables 😭, but I wonder why Gaijin can’t code the orientation logic before launch, why do they need an orientation and heading “autopilot” after the launch, that wastes energy and time and creates this weird double loft that makes no sense in game and IRL.